-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting the endpoint_id of all the uninitialized endpoints to invalid instead of 0 #13814
Setting the endpoint_id of all the uninitialized endpoints to invalid instead of 0 #13814
Conversation
c8d20d4
to
5b1c14b
Compare
PR #13814: Size comparison from 5394388 to 5b1c14b Increases (1 build for linux)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
@bzbarsky-apple PTAL, wrt your comment #12934 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So first of all, EMBER_AF_INVALID_ENDPOINT is actually set to a value which is a valid endpoint id (in Matter, which has a different range of endpoint ids than Zigbee). So that would need to change at the very least.
But past that, I am trying to understand the underlying problem here that #12934 was trying to solve. Why would endpoint 0 be a dynamic endpoint? Is this a device with only dynamic endpoints configured?
5b1c14b
to
0b2a6e8
Compare
Updated the EMBER_AF_INVALID_ENDPOINT to 0xFFFF.
Yes, experimenting to create all the endpoints dynamically. |
PR #13814: Size comparison from 5227f3e to 0b2a6e8 Increases (1 build for linux)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
0b2a6e8
to
cfa5121
Compare
PR #13814: Size comparison from f0f5de0 to cfa5121 Full report (10 builds for cyw30739, k32w, p6, qpg, telink)
|
/rebase |
cfa5121
to
b64fe67
Compare
PR #13814: Size comparison from e169fcf to b64fe67 Increases (1 build for linux)
Full report (33 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Setting the endpoint_id of all the uninitialized endpoints to invalid instead of 0
Problem
Fixing corner cases where dynamic endpoints are added and removed.
Change overview
Testing